Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3913: Add sirskernel to refpix reference types #9261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

JP-3913: Add sirskernel to refpix reference types #9261

wants to merge 3 commits into from
+37 −4

Conversation

melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Mar 10, 2025 •
edited
Loading

Resolves JP-3913

Add sirskernel to the reference types for the refpix step, so that override_sirskernel is available as a parameter.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@melanieclarke melanieclarke added this to the Build 11.3 milestone Mar 10, 2025
@melanieclarke
Copy link
Collaborator Author

melanieclarke commented Mar 10, 2025 •
edited
Loading

Regression tests running here:
https://github.com/spacetelescope/RegressionTests/actions/runs/13771431669

It looks like all instruments have at least an "N/A" value for this reference type, so I expect no failures.

Edit: no failures.

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (3685b97) to head (1171984).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9261   +/-   ##
=======================================
  Coverage   72.61%   72.61%           
=======================================
  Files         371      371           
  Lines       37105    37105           
=======================================
  Hits        26945    26945           
  Misses      10160    10160

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke marked this pull request as ready for review March 10, 2025 19:50
@melanieclarke melanieclarke requested review from a team as code owners March 10, 2025 19:50
@melanieclarke melanieclarke requested a review from tapastro March 10, 2025 19:50
@drlaw1558
Copy link
Collaborator

Looks like this is working for me. We should probably update the docs at the same time; sirskernel is missing from the reference files section of the refpix docs too.

@melanieclarke melanieclarke marked this pull request as draft March 10, 2025 19:58
@melanieclarke
Copy link
Collaborator Author

@drlaw1558 - I added some minimal documentation for the SIRSKERNEL file. Is there anything more you'd like to add?

@melanieclarke melanieclarke force-pushed the jp-3913 branch 2 times, most recently from 5bb2210 to f8a3ee8 Compare March 11, 2025 13:48
@drlaw1558
Copy link
Collaborator

Looks good to me, thanks!

@melanieclarke melanieclarke marked this pull request as ready for review March 11, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapastro tapastro Awaiting requested review from tapastro

@penaguerrero penaguerrero Awaiting requested review from penaguerrero

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation refpix
Projects
None yet
Milestone
Build 11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@melanieclarke @drlaw1558